Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

Mozilla Central Snippet blocking #2017

Closed
sarracini opened this issue Jan 18, 2017 · 4 comments
Closed

Mozilla Central Snippet blocking #2017

sarracini opened this issue Jan 18, 2017 · 4 comments

Comments

@sarracini
Copy link
Contributor

Split from #1985. The closed/dismissed snippet needs to be persisted so it won't show up again. There is also logic for some snippets which are not allowed to be dismissed or closed at all

@k88hudson k88hudson mentioned this issue Jan 18, 2017
7 tasks
@Mardak Mardak mentioned this issue Jan 18, 2017
5 tasks
@Mardak Mardak added MVP and removed MVP labels Jan 19, 2017
@Mardak Mardak moved this from Unassigned to Milestone 4 in Land in Nightly / Graduate Mar 15, 2017
@rlr rlr added the Parity label May 5, 2017
@glogiotatidis
Copy link
Contributor

There is also logic for some snippets which are not allowed to be dismissed or closed at all

Hey Jean (@jkt230) do we need to have snippets that are not allowed to be blocked?

@jkt230
Copy link

jkt230 commented Jul 12, 2017

@glogiotatidis For the current about:home, we don't have snippets that are not allowed to be blocked. But in the future with the new Activity Stream look and feel, we may use snippets for rare occasions like security alerts, etc. But even then, we should give users the option to block it. So to answer your question - we do not have snippets that are not allowed to be blocked.

@glogiotatidis
Copy link
Contributor

For the current about:home, we don't have snippets that are not allowed to be blocked.

Yes we do. If you don't check the "Blockable" checkbox people cannot block the snippet. I don't want to hijack this thread which is about AS, so lets get this to email if it's still unclear.

But even then, we should give users the option to block it

So all snippets will be blockable on AS and therefore we don't need to support unblockable snippets on AS. Correct @jkt230 ?

@jkt230
Copy link

jkt230 commented Jul 12, 2017

@glogiotatidis Correct!

@Mardak Mardak added the fx56 label Jul 26, 2017
@sarracini sarracini added Blocked and removed Blocked labels Jul 26, 2017
@k88hudson k88hudson self-assigned this Jul 26, 2017
@k88hudson k88hudson changed the title Mozilla Central Snippet persist/disallow closing Mozilla Central Snippet blocking Jul 26, 2017
k88hudson added a commit to k88hudson/activity-stream that referenced this issue Jul 27, 2017
k88hudson added a commit to k88hudson/activity-stream that referenced this issue Jul 27, 2017
sarracini added a commit that referenced this issue Jul 27, 2017
feat(mc): #2017 Add blocking to snippets.js
@Mardak Mardak removed the MVP label Jul 28, 2017
@sarracini sarracini moved this from Milestone 4 to Complete in Land in Nightly / Graduate Aug 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

No branches or pull requests

6 participants