-
Notifications
You must be signed in to change notification settings - Fork 113
Mozilla Central Snippet blocking #2017
Comments
Hey Jean (@jkt230) do we need to have snippets that are not allowed to be blocked? |
@glogiotatidis For the current about:home, we don't have snippets that are not allowed to be blocked. But in the future with the new Activity Stream look and feel, we may use snippets for rare occasions like security alerts, etc. But even then, we should give users the option to block it. So to answer your question - we do not have snippets that are not allowed to be blocked. |
Yes we do. If you don't check the "Blockable" checkbox people cannot block the snippet. I don't want to hijack this thread which is about AS, so lets get this to email if it's still unclear.
So all snippets will be blockable on AS and therefore we don't need to support unblockable snippets on AS. Correct @jkt230 ? |
@glogiotatidis Correct! |
feat(mc): #2017 Add blocking to snippets.js
Split from #1985. The closed/dismissed snippet needs to be persisted so it won't show up again. There is also logic for some snippets which are not allowed to be dismissed or closed at all
The text was updated successfully, but these errors were encountered: