Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

Delay loading of content search until necessary #2917

Closed
Mardak opened this issue Jul 20, 2017 · 4 comments
Closed

Delay loading of content search until necessary #2917

Mardak opened this issue Jul 20, 2017 · 4 comments
Assignees
@k88hudson

Comments

@Mardak
Copy link
Member

Mardak commented Jul 20, 2017

From mconley's joy of coding 106 notes:

https://www.evernote.com/shard/s434/sh/4cc743c4-933f-4917-af1e-343acf32a096/eb0c9f60ac08f6f0

Leaking Blob URI:
contentSearchUI probably leaks Blob URIs if the favicons for the one-off buttons are never shown (like, if the defaultEngine is set, but the user never tries to do a search in about:newtab).
@k88hudson
Copy link
Contributor

Do you mean loading the file at all or initializing ContentSearchUIController

@k88hudson k88hudson self-assigned this Jul 20, 2017
k88hudson added a commit to k88hudson/activity-stream that referenced this issue Jul 20, 2017
@k88hudson
fix(mc): mozilla#2917 Only ininitalize search on focus
ea372b4
k88hudson added a commit to k88hudson/activity-stream that referenced this issue Jul 20, 2017
@k88hudson
fix(mc): mozilla#2917 Only initialize search on focus
128e39a
@k88hudson k88hudson mentioned this issue Jul 20, 2017
Merged
@Mardak
Copy link
Member Author

Mardak commented Jul 20, 2017

Do you mean loading the file at all or initializing ContentSearchUIController

Whatever is causing the URL blob object to exist. I would think it's from constructing as you've done in #2921.

k88hudson added a commit to k88hudson/activity-stream that referenced this issue Jul 20, 2017
@k88hudson
fix(mc): mozilla#2917 Only initialize search on focus
227a2fc
k88hudson added a commit that referenced this issue Jul 20, 2017
@k88hudson
Merge pull request #2921 from k88hudson/gh2917
4d4bd12 
fix(mc): #2917 Only initialize search on focus
Mardak added a commit that referenced this issue Jul 20, 2017
@Mardak
Revert "fix(mc): #2917 Only initialize search on focus"
eade774
Mardak added a commit that referenced this issue Jul 20, 2017
@Mardak
Revert "fix(mc): #2917 Only initialize search on focus" (#2926)
9eeb01c
@Mardak Mardak reopened this Jul 20, 2017
@Mardak
Copy link
Member Author

Mardak commented Jul 20, 2017

Backed out by #2926

@jaredlockhart jaredlockhart added P1 and removed P1 labels Jul 24, 2017
@jaredlockhart
Copy link
Contributor

Closing this until it is confirmed that we need this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@k88hudson k88hudson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaredlockhart @Mardak @k88hudson