My top sites are tripping out .......

[sarracini]

So I had no pinned top sites, and then I pinned a top site and all of a sudden:

And then the extra 3 wouldn't go away no matter how many times I opened a new tab......

cc @dmose @k88hudson @Mardak @rlr any idea what could be going on here?

[Mardak]

Did you pin just one? There was an issue filed at some point where multiple top sites were pinned? Notice the "extra" ones after 12 are also pinned. Perhaps there's some logic making sure pinned sites are always visible?

[sarracini]

yeah I had pinned the first one in the second row and then my top sites updated to that. I'm guessing the three that are pinned at the bottom were perhaps pinned from tiles, but didn't show up in activity stream until I kicked it with pinning one that showed up in top sites

[piatra]

My thought: On pinning the website we hit this case statement which does not call slice. If you previously had pinned sites (not one of the 12 already presented) in NewTabUtils.pinnedLinks.links they will all be added resulting in more than 12 topsites.

[piatra]

I managed to reproduce the issue and confirm it's the problem described in the previous comment.