Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

Have the locale ready to dispatch with INIT #2999

Closed
Mardak opened this issue Jul 27, 2017 · 3 comments
Closed

Have the locale ready to dispatch with INIT #2999

Mardak opened this issue Jul 27, 2017 · 3 comments
Labels

Comments

@Mardak
Copy link
Member

Mardak commented Jul 27, 2017

In #2991, we looked into having TopStoriesFeed get App.locale state, but it was clunky in having its init partially deferred. Instead ActivityStream should dispatch INIT with locale set already. Not sure if this also means ActivityStream instead of LocalizationFeed should be watching for the locale change so that the feed is specifically for updating strings..

@Mardak
Copy link
Member Author

Mardak commented Sep 14, 2017

Unclear if this is still desired now that LocalizationFeed uses user preferred languages as opposed to app locale.

@tspurway tspurway added this to the 21 Jump Street milestone Sep 18, 2017
@jenn-chaulk jenn-chaulk modified the milestones: Jump Street (October 15), Backlog Sep 28, 2017
@Mardak
Copy link
Member Author

Mardak commented Jan 24, 2018

#3920 switched us back to (negotiated) app locales

@Mardak
Copy link
Member Author

Mardak commented Jan 24, 2018

Services.locale.getAppLocaleAsLangTag is simple enough to call to not need to stash in our own redux store as content won't need it anyway because the locale is part of the html.

@Mardak Mardak closed this as completed Jan 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants