feat(systemaddon): Get Pocket feed for the appropriate locale. Closes… #2991
Conversation
| this.stories_endpoint = this._produceUrlWithApiKey(options.stories_endpoint, apiKey); | ||
| this.topics_endpoint = this._produceUrlWithApiKey(options.topics_endpoint, apiKey); | ||
| const locale = Services.locale.getRequestedLocale(); | ||
| this.stories_endpoint = this._produceFinalEndpointUrl(options.stories_endpoint, apiKey, locale); |
There was a problem hiding this comment.
I see that fetch* is called later in init, but does this actually need to happen during init? We ran into an issue where reftests were failing because network connections were being made aggressively (and denied).
But even ignoring the network connection issue (already fixed for now), instead of using Services.locale.getRequestedLocale, onAction should watch for LOCALE_UPDATED and have a helper method set the endpoint and maybe fetch. The helper would be called from LOCALE_UPDATED and init and can get the locale from this.store.getState().App.locale
There was a problem hiding this comment.
Yes, I believe calling fetch* in init is best. We want this to happen as soon as possible to increase the chance we have initial/fresh stories and topics fetched when a new tab is opened.
I will add the refactoring you requested.
There was a problem hiding this comment.
We don't need to fix the "later" than init network now, but I was thinking not that much long after init. It's just that anything done synchronously during the constructor and INIT counts against one of the talos performance metrics.
Fix #2974.
Currently requesting other locales than en-* will return the exact same content, so there's no harm in putting this in now. Once other language feeds are ready they should just work (we won't need any client-side changes then).
Relying on accept-lang is possible in a future endpoint version, but in the meantime let's use the locale_lang request parameter. This is also consistent with A-S lang settings, as there we're not relying on accept-lang, but on general.useragent.locale.