Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

Add section called "Highlights" #3147

Closed
Mardak opened this issue Aug 10, 2017 · 4 comments
Closed

Add section called "Highlights" #3147

Mardak opened this issue Aug 10, 2017 · 4 comments

Comments

@Mardak
Copy link
Member

Mardak commented Aug 10, 2017

Fill as many cards on Highlights with visited bookmarks up to 5 days old: "Bookmarked"
Fill the rest with most recent history item (can be bookmarked): "Visited"
Looks like the total is 9 cards with no timestamp but "Bookmarked" or "Visited" with matching icon. If a card's url is actually bookmarked, its context menu should have "Remove Bookmark".
None of the highlights should exactly match the url of a recently bookmarked or recently visited top site. But pages/articles visited from the top site should appear as Highlights.
The prefs from #3155 section allows for turning off of bookmarks and/or history.

image

https://trello.com/c/kijapFZ2/156-i-want-to-see-a-highlights-section-on-new-tab

Strings:

  • header_highlights=Highlights
  • highlights_empty_state=Start browsing, and we’ll show some of the great articles, videos, and other pages you’ve recently visited or bookmarked here.

https://mozilla.invisionapp.com/share/FUD0ADOYE#/screens/248319677_NewTab_-_Empty_States

@Mardak Mardak created this issue from a note in Release Activity Stream in Firefox 57 (Highlights) Aug 10, 2017
@Mardak Mardak moved this from Highlights to SSS (Sections / Stories / Snippets) in Release Activity Stream in Firefox 57 Aug 10, 2017
@Mardak Mardak moved this from SSS (Search / Sections / Snippets) to Sections in Release Activity Stream in Firefox 57 Aug 10, 2017
@Mardak Mardak modified the milestone: Free Willy (August 20) Aug 11, 2017
@sarracini sarracini added the P1 label Aug 14, 2017
@sarracini
Copy link
Contributor

sarracini commented Aug 14, 2017

Blocked on metadata from #2354

@Mardak
Copy link
Member Author

Mardak commented Aug 30, 2017

"This should work the same way as Pocket" so use section manager and reuse telemetry provided by section manager. Cards should already automatically send click telemetry.

@tspurway tspurway assigned rlr and unassigned piatra Aug 30, 2017
@Mardak
Copy link
Member Author

Mardak commented Sep 1, 2017

Bookmarks should be always be shown even without metadata "because it’s a bookmark it’s more likely to feel familiar even if it’s missing thumbnails." Whereas a history page should only be shown if there's an image

@Mardak
Copy link
Member Author

Mardak commented Sep 6, 2017

Updated initial comment to note some additional behaviors from UX:

  • old bookmarks can appear as "Visited" but context menu will show "Remove Bookmark"
  • top site urls should not appear in Highlights (but their pages/articles should appear)

rlr added a commit to rlr/activity-streams that referenced this issue Sep 6, 2017
rlr added a commit to rlr/activity-streams that referenced this issue Sep 7, 2017
rlr added a commit to rlr/activity-streams that referenced this issue Sep 7, 2017
rlr added a commit to rlr/activity-streams that referenced this issue Sep 7, 2017
rlr added a commit to rlr/activity-streams that referenced this issue Sep 7, 2017
rlr added a commit to rlr/activity-streams that referenced this issue Sep 7, 2017
@Mardak Mardak removed the Blocked label Sep 8, 2017
@Mardak Mardak moved this from Sections to Highlights in Release Activity Stream in Firefox 57 Sep 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

No branches or pull requests

5 participants