Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

Add API to give Snippets in Activity Stream control over when to show onboarding #3263

Closed
k88hudson opened this issue Aug 28, 2017 · 5 comments
Closed

Add API to give Snippets in Activity Stream control over when to show onboarding #3263

k88hudson opened this issue Aug 28, 2017 · 5 comments
Assignees
@k88hudson
Labels
Bugzilla fx57 Has PR P1 Uplifted
Projects
Release Activity Stream in Firefox 57
Milestone
Inception (Octobe...

Comments

@k88hudson
Copy link
Contributor

https://bugzilla.mozilla.org/show_bug.cgi?id=1393489
@k88hudson k88hudson added the fx57 label Aug 28, 2017
@k88hudson k88hudson self-assigned this Aug 28, 2017
@Mardak Mardak added the P1 label Aug 28, 2017
@k88hudson
Copy link
Contributor Author

I have a working patch for this, just writing some tests now

@Mardak Mardak added the Bugzilla label Sep 2, 2017
@tspurway
Copy link
Contributor

@k88hudson, does this have a PR?

@Mardak
Copy link
Member

Mardak commented Sep 13, 2017

Just attached to mozreview https://bugzilla.mozilla.org/attachment.cgi?id=8907692

k88hudson added a commit to k88hudson/activity-stream that referenced this issue Sep 27, 2017
@k88hudson
fix(snippets): mozilla#3263 Give snippets API to override onboarding
c9046ae
k88hudson added a commit to k88hudson/activity-stream that referenced this issue Sep 27, 2017
@k88hudson
fix(snippets): mozilla#3263 Give snippets API to override onboarding
b15065f
k88hudson added a commit to k88hudson/activity-stream that referenced this issue Sep 27, 2017
@k88hudson
fix(snippets): mozilla#3263 Give snippets API to override onboarding
92f21d6
@k88hudson k88hudson mentioned this issue Sep 27, 2017
Merged
@Mardak
Copy link
Member

Mardak commented Sep 27, 2017

Fixed by #3542

@Mardak Mardak closed this as completed Sep 27, 2017
@Mardak
Copy link
Member

Mardak commented Oct 3, 2017

https://hg.mozilla.org/releases/mozilla-beta/rev/79375774e4fe

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@k88hudson k88hudson

Labels
Bugzilla fx57 Has PR P1 Uplifted
Projects
No open projects
Release Activity Stream in Firefox 57
Snippets
Milestone
Inception (October 1)
Development

No branches or pull requests
3 participants
@tspurway @Mardak @k88hudson