Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

Missing, white, loading, other poor quality screenshots of some sites #3509

Closed
1 of 4 tasks
Mardak opened this issue Sep 16, 2017 · 4 comments
Closed
1 of 4 tasks

Missing, white, loading, other poor quality screenshots of some sites #3509

Mardak opened this issue Sep 16, 2017 · 4 comments

Comments

@Mardak
Copy link
Member

Mardak commented Sep 16, 2017

With the fancy new #3507, I put in 100 for topSitesCount and noticed a few problems from my history:

mint and schwab screenshot an all white section (maybe still loading?):
image
https://mint.intuit.com/overview.event
image
https://www.schwab.com/

macrumors, mortgagequestions, my.nintendo don't screenshot at all:
image
https://www.macrumors.com/
image
https://www.mortgagequestions.com/
image
https://my.nintendo.com/
(Must be something with the "M"s.)

nve.ecofactor screenshots loading spinner:
image
https://nve.ecofactor.com/

britishairways screenshots the language prompt overlay (probably can't do much here):
image
https://www.britishairways.com/en-gb/executive-club/spending-avios/reward-flights

various google (mail, docs) have login (probably can't do much here):
image
https://mail.google.com/
https://docs.google.com/

@Mardak Mardak changed the title Missing or white screenshots of some sites Missing, white, loading, other poor quality screenshots of some sites Sep 16, 2017
@Mardak
Copy link
Member Author

Mardak commented Sep 16, 2017

It seems like after restarting, some sites (not listed in the previous comment) that didn't get a screenshot ended up getting a screenshot. Maybe some queue got maxxed or data got lost? Or some broken state from some previous screenshot that prevented screenshotting these other sites?

Edit: Actually my.nintendo ended up screenshotting the second time:
image

@Mardak
Copy link
Member Author

Mardak commented Sep 25, 2017

Let's just increase the settle time as a fix for this and ignore the other problems as as sites adopt rich icons, the problem goes away.

@Valeryan24
Copy link

Valeryan24 commented Oct 11, 2017

Hello,

Firefox 57 will be a capital step in Mozilla history, with many significant and important changes in substance, a good reception and perception by users is absolutely necessary. And for that, esthetic, ergonomics, first impression are decisive, because many times people make huge critics on social medias just after a look, which can be viral...

This home and "New tab" page is something all users will see at first and very often, it can't be imperfect, and as it is designed now, it's sometime a bit ugly.

I understand that you certainly want to have same presentation (and perhaps code) for all plateforms (desktop, mobile...), but on a large screen, having so little thumbs is not so nice - in FF before 57 they were larger and we could put more than 2 x 6 on 2 rows- but I guess people wanting a better experience will be able to install addons like SpeedDial to customize precisely.

Problem is that, as said in this issue, lots of sites don't work with this design : either the favicon is not displayed on the bottom right, often screenshot does not show the entire page resume but only a (sometime big pixilated) icon, some site need a login and we only see the form, or just a blank square...

Moreover, as thumbs are small, name of the site is not displayed entirely.

Tested on Ubuntu, ppa Firefox Next, version 57.0b6, see the picture for my 12 examples - I can make more tests on french pages to provide more informations.

I don't know if there is enough time to correct it for "all" pages before FF 57 release, or if design can still be changed / reverted, but imho this kind of presentation with heterogeneous thumbnails of most visited sites will provoke a feeling of unwarranted rejection among the general public, and obliterate the rest of positive new features...

ff57

@Mardak
Copy link
Member Author

Mardak commented Jan 22, 2018

There's various open [thumbnails] bugs that can be found on bugzilla:

https://bugzilla.mozilla.org/buglist.cgi?resolution=---&status_whiteboard=[thumbnails]

@Mardak Mardak closed this as completed Jan 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants