Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

Unexpected behaviors when actions happen before INIT #3697

Closed
Mardak opened this issue Oct 12, 2017 · 1 comment · Fixed by #3695
Closed

Unexpected behaviors when actions happen before INIT #3697

Mardak opened this issue Oct 12, 2017 · 1 comment · Fixed by #3695

Comments

@Mardak
Copy link
Member

Mardak commented Oct 12, 2017

In investigating #3695 for the actual cause for #3377, turns out if Activity Stream is late to load and simulates a NEW_TAB_INIT/LOAD for existing pages, those might happen before INIT, which theoretically should be the very first action?

Here createChannel simulates "RemotePage:Init" and "RemotePage:Load" before "INIT". I guess ActivityStreamMessageChannel should only simulate after INIT?

this._messageChannel.createChannel();
// Dispatch an initial action after all enabled feeds are ready
if (initAction) {
this.dispatch(initAction);

@k88hudson

@piatra
Copy link
Contributor

piatra commented Oct 18, 2017

Fixed by #3695.

@piatra piatra closed this as completed Oct 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants