Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

New profiles trigger a bunch of places queries for highlights #3730

Closed
Mardak opened this issue Oct 18, 2017 · 2 comments
Closed

New profiles trigger a bunch of places queries for highlights #3730

Mardak opened this issue Oct 18, 2017 · 2 comments

Comments

@Mardak
Copy link
Member

Mardak commented Oct 18, 2017

Noticed when testing #3695. Regressed by #3675:

case at.PLACES_BOOKMARK_ADDED:
case at.PLACES_BOOKMARK_REMOVED:
this.linksCache.expire();
this.fetchHighlights({broadcast: false});
break;

New profiles create some bookmarks causing highlights to expire the cache. We end up requesting new highlights but also get none because they're too recently bookmarked (probably default bookmarks).

@piatra

@piatra
Copy link
Contributor

piatra commented Oct 18, 2017

I already created #3724 to handle this.

@Mardak
Copy link
Member Author

Mardak commented Oct 18, 2017

Ah doh. too many issues ;)

@Mardak Mardak closed this as completed Oct 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants