Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

fix (addon): #1228 simplify url hiding #1308

Merged
merged 1 commit into from Sep 15, 2016
Merged

fix (addon): #1228 simplify url hiding #1308

merged 1 commit into from Sep 15, 2016

Conversation

rlr
Copy link
Contributor

@rlr rlr commented Sep 15, 2016

Fixes #1228

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 92.489% when pulling d6c0aed on rlr:gh1228/simpler-url-hiding into 3b11d1d on mozilla:master.

@rlr
Copy link
Contributor Author

rlr commented Sep 15, 2016

@k88hudson I changed router to use memory instead of the hash. What you think? All seems to work fine.

k88hudson
k88hudson approved these changes Sep 15, 2016
View reviewed changes
Copy link
Contributor

@k88hudson k88hudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES!!! Awesome!!!!! 👍 👍👍👍

@k88hudson k88hudson assigned rlr and unassigned k88hudson Sep 15, 2016
@rlr rlr merged commit 999e2c6 into mozilla:master Sep 15, 2016
@rlr rlr deleted the gh1228/simpler-url-hiding branch September 15, 2016 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@k88hudson k88hudson k88hudson approved these changes

Assignees

@rlr rlr

Labels
PR / R+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rlr @coveralls @k88hudson @tspurway