Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

String change to be consistent with desktop #2135

Merged
merged 1 commit into from Feb 7, 2017
Merged

String change to be consistent with desktop #2135

merged 1 commit into from Feb 7, 2017

Conversation

da2x
Copy link
Contributor

@da2x da2x commented Feb 7, 2017 •
edited by oyiptong

Firefox desktop uses the strings Open Link in a New Window and Open Link in a New Private Window. Change to make string consistent with desktop.

This change is Reviewable

@da2x
String change to be consistent with desktop
c5d5d49 
Firefox desktop uses the strings `Open Link in a New Window` and
`Open Link in a New Private Window`. Change to make string
consistent with desktop.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.118% when pulling c5d5d49 on da2x:patch-1 into 4334de4 on mozilla:master.

@sarracini sarracini merged commit a4bc134 into mozilla:master Feb 7, 2017
@Mardak
Copy link
Member

Mardak commented Feb 7, 2017 •
edited

I believe typically string changes need a id bump, e.g., menu_action_open_private_window2. As localizers haven't started localizing yet, we should be okay for now if we push the new string to the strings repository.

https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sarracini sarracini sarracini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@da2x @coveralls @Mardak @sarracini