Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

fix(systemaddon): Closes #2930 Bookmarking from context menu does nothing #2939

Merged
merged 1 commit into from
Jul 24, 2017

Conversation

sarracini
Copy link
Contributor

Adds an action in the reducer for sections for adding and removing bookmarks

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.407% when pulling 82dfd9f on sarracini:gh2930 into 75e5bec on mozilla:master.

Copy link
Contributor

@AdamHillier AdamHillier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just the one typo

const nextState = Sections(undefined, {type: at.PLACES_BOOKMARK_REMOVED});
assert.equal(nextState, INITIAL_STATE.Sections);
});
it("should remove the bookmard when PLACES_BOOKMARK_REMOVED is received", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo here - "bookmark"

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.407% when pulling 0da41e7 on sarracini:gh2930 into 75e5bec on mozilla:master.

@sarracini sarracini merged commit 91492c2 into mozilla:master Jul 24, 2017
@as-pine-proxy
Copy link
Collaborator

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants