Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

feat(mc): #1985 Only show snippets when onboarding is finished #2995

Merged
merged 1 commit into from
Jul 28, 2017
Merged

feat(mc): #1985 Only show snippets when onboarding is finished #2995

merged 1 commit into from
Jul 28, 2017

Conversation

k88hudson
Copy link
Contributor

No description provided.

@k88hudson k88hudson requested a review from dmose July 27, 2017 19:55
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.407% when pulling ad6985b on k88hudson:onboarding-snippets into 580602e on mozilla:master.

dmose
dmose previously requested changes Jul 27, 2017
View reviewed changes
Copy link
Member

@dmose dmose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs automated tests.

@dmose dmose assigned k88hudson and unassigned dmose Jul 27, 2017
@k88hudson k88hudson assigned dmose and unassigned k88hudson Jul 28, 2017
@k88hudson k88hudson requested a review from dmose July 28, 2017 17:56
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.407% when pulling 5c3ea05 on k88hudson:onboarding-snippets into 580602e on mozilla:master.

@sarracini sarracini requested review from sarracini and removed request for dmose July 28, 2017 19:51
@sarracini sarracini assigned sarracini and unassigned dmose Jul 28, 2017
@sarracini sarracini dismissed dmose’s stale review July 28, 2017 19:51

I reviewed instead

@sarracini sarracini assigned k88hudson and unassigned sarracini Jul 28, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.407% when pulling 4e164b1 on k88hudson:onboarding-snippets into 0675a44 on mozilla:master.

@k88hudson k88hudson merged commit 7fcbda4 into mozilla:master Jul 28, 2017
@as-pine-proxy
Copy link
Collaborator

Treeherder: 0777574108df3f47c033c844594fcebb1c152713

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sarracini sarracini sarracini approved these changes

@dmose dmose dmose left review comments

Assignees

@k88hudson k88hudson

Labels
PR / R+ pushed-to-pine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k88hudson @coveralls @as-pine-proxy @dmose @sarracini