This repository has been archived by the owner on Feb 29, 2020. It is now read-only.
feat(topstories): Hide preference section for unsupported locales #3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mardak
suggested changes
Jul 27, 2017
system-addon/lib/ActivityStream.jsm
Outdated
| const SECTIONS = new Map([ | ||
| ["topstories", { | ||
| feed: TopStoriesFeed, | ||
| prefTitle: "Fetches content recommendations from a configurable content provider", | ||
| // for now, we only want to show top stories by default to the following locales | ||
| showByDefault: ["en-US", "en-CA"].includes(Services.locale.getRequestedLocale()) | ||
| showByDefault: showTopStoriesByDefault |
There was a problem hiding this comment.
Keep the default inline with topstories, i.e., undo this change. So that the comment line makes sense.
| @@ -84,7 +85,8 @@ const PREFS_CONFIG = new Map([ | |||
| "api_key_pref": "extensions.pocket.oAuthConsumerKey", | |||
| "provider_name": "Pocket", | |||
| "provider_icon": "pocket", | |||
| "provider_description": "pocket_feedback_body" | |||
| "provider_description": "pocket_feedback_body", | |||
| "hidden": ${!showTopStoriesByDefault} | |||
There was a problem hiding this comment.
Instead just do ${!SECTIONS.get("topstories").showByDefault}
Mardak
approved these changes
Jul 27, 2017
| @@ -24,13 +24,14 @@ const {TopStoriesFeed} = Cu.import("resource://activity-stream/lib/TopStoriesFee | |||
|
|
|||
| const REASON_ADDON_UNINSTALL = 6; | |||
|
|
|||
| // For now, we only want to show top stories by default to the following locales | |||
| const showTopStoriesByDefault = ["en-US", "en-CA"].includes(Services.locale.getRequestedLocale()); | |||
There was a problem hiding this comment.
This is fine with the comment line moved up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion for a simple fix #2973.
Reason I used "hidden" (negated showByDefault) is so nobody has to reset their prefs to keep seeing top stories.