This repository has been archived by the owner on Feb 29, 2020. It is now read-only.
Add extra space for snippets, fix various CSS stuff #3047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarracini
approved these changes
Jul 31, 2017
| margin-top: $topic-margin-top; | ||
| line-height: 1.6; |
There was a problem hiding this comment.
was this meant to stay here?
There was a problem hiding this comment.
like, do you need both the multiplier and also the 16px? i remember the 16px came from an average number on both windows and osx looking pretty good, i wonder if adding the multiplier will change that
There was a problem hiding this comment.
I added the multiplier for the small sizes so that the text looks a little better wrapped. The 16px is for the full size
|
There was a commit referring to issue 3000. Did you mean a different one? |
|
I'm assuming the 3000 reference should have been 3001. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3001. I also added a couple of commits to fix some responsive styling for the topics part of the Top Stories section, and fixed the vertical spacing being uneven