Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

Fix(l10n): closes #3003, makes locale fallback work #3048

Merged
merged 1 commit into from
Jul 31, 2017
Merged

Fix(l10n): closes #3003, makes locale fallback work #3048

merged 1 commit into from
Jul 31, 2017

Conversation

dmose
Copy link
Member

@dmose dmose commented Jul 31, 2017 •
edited by Mardak
Loading

Fix #3003. How to test:

  1. download a de-DE nightly build
  2. in about:config, set the various appropriate xpinstall prefs to false
  3. npm run packagemc
  4. from about:addons, use the gear dropdown menu to install the .xpi
  5. open a new tab, verify that the words are in german rather than English

@dmose dmose requested a review from Mardak July 31, 2017 23:43
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.407% when pulling 1774fb2 on dmose:negotiateLocales into 2445903 on mozilla:master.

Mardak
Mardak approved these changes Jul 31, 2017
View reviewed changes
Copy link
Member

@Mardak Mardak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit on array from array

system-addon/lib/LocalizationFeed.jsm Outdated
// the best locale
let locale = Services.locale.negotiateLanguages(
Services.locale.getAppLocalesAsLangTags(), // desired locales
Array.from(Object.keys(this.allStrings)), // available locales
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Object.keys already returns an array. (We're not getting Iterator keys from Set/Map.)

@Mardak Mardak assigned dmose and unassigned Mardak Jul 31, 2017
@dmose
Copy link
Member Author

dmose commented Jul 31, 2017

Nit fixed.

@dmose dmose merged commit c51a689 into mozilla:master Jul 31, 2017
@as-pine-proxy
Copy link
Collaborator

Treeherder: 1eb543c611e0da588ac54793767efe3355077bb5

@Mardak Mardak mentioned this pull request Aug 1, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Mardak Mardak Mardak approved these changes

Assignees

@dmose dmose

Labels
PR / R+ with nits pushed-to-pine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dmose @coveralls @as-pine-proxy @Mardak