This repository has been archived by the owner on Feb 29, 2020. It is now read-only.
fix(telemetry): #3118 workaround 500s apparent topsites_first_paint_ts #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mardak
reviewed
Aug 10, 2017
system-addon/lib/TelemetryFeed.jsm
Outdated
| @@ -266,6 +265,13 @@ this.TelemetryFeed = class TelemetryFeed { | |||
| // get blows up. | |||
| let session = this.sessions.get(port); | |||
|
|
|||
| // Partial workaround for #3118; avoids the worst incorrect associations of | |||
| // times with browsers, and should result in no longer having apparent load | |||
| // times of 500,000 ms. Better fix for more cases forthcoming. | |||
There was a problem hiding this comment.
The 500sec comment doesn't really make any sense by itself. Probably better to just say to associate the load trigger with the visibility event as the user is most likely associating the trigger to the tab just shown. Could maybe note that this is to not associate with a preloaded browser as those don't get the event until shown.
There was a problem hiding this comment.
Good catch, the 500sec was pretty context-free. :-)
Mardak
reviewed
Aug 10, 2017
| assert.calledOnce(instance.setLoadTriggerInfo); | ||
| assert.calledWithExactly(instance.setLoadTriggerInfo, "port123"); | ||
| assert.include(instance.sessions.get("port123").perf, data); | ||
| }); |
There was a problem hiding this comment.
A negative test would be good sanity check. I.e., non-visibility_event_rcvd_ts doesn't call setLoadTriggerInfo
Mardak
approved these changes
Aug 10, 2017
dmose
force-pushed
the
improve-loadtime-correctness
branch
from
c03f842
to
80565ac
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3118. r?Mardak This should be the exact fix we already discussed.