This repository has been archived by the owner on Feb 29, 2020. It is now read-only.
fix(highlights): Ensure that Highlights are refreshed on init. #3451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlr
reviewed
Sep 13, 2017
system-addon/lib/HighlightsFeed.jsm
Outdated
| // We need TopSites to have been initialised for deduping | ||
| if (!this.store.getState().TopSites.initialized) { | ||
| await new Promise(resolve => { | ||
| const unsubscribe = this.store.subscribe(async () => { |
There was a problem hiding this comment.
is this async required since there are no awaits inside? I am still an async/await newb so I'm not sure.
There was a problem hiding this comment.
Ah no it's not that's a good point, cheers
rlr
approved these changes
Sep 13, 2017
|
Did you end up pushing this to try to check talos? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3410. And fix #3411 too.