Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (systemaddom): #3148 make the sections (+Top Sites) collapsible #3617

Merged
merged 1 commit into from Oct 6, 2017

Conversation

Projects
None yet
5 participants
@rlr
Copy link
Member

commented Sep 27, 2017

Once again, a lot of the code changes is moving stuff around.

Fixes #3148

@rlr rlr force-pushed the rlr:gh3148/collapsible-sections branch 6 times, most recently from a203e78 to a84dab5 Sep 27, 2017

@rlr rlr requested review from k88hudson and csadilek Oct 4, 2017

@rlr rlr force-pushed the rlr:gh3148/collapsible-sections branch from a84dab5 to b0c07cd Oct 4, 2017

@csadilek
Copy link
Collaborator

left a comment

Works well! Only found one issue: A collapsed section should not send view impressions but currently does, see dispatchImpressionStats().

So, we'd need to find a way to send view impressions when the section is expanded, similar to what we do with the visibility change handler.

background-image: url('#{$image-path}glyph-arrowhead-down-12.svg');
background-size: $smaller-icon-size;
height: $smaller-icon-size;
transform: rotate(270deg);

This comment has been minimized.

Copy link
@Mardak

Mardak Oct 5, 2017

Member

Probably need 90deg for rtl?

@rlr rlr force-pushed the rlr:gh3148/collapsible-sections branch from b0c07cd to 9d28eae Oct 5, 2017

@rlr

This comment has been minimized.

Copy link
Member Author

commented Oct 5, 2017

@csadilek I've addressed the impressions issue here 9d28eae

@csadilek

This comment has been minimized.

Copy link
Collaborator

commented Oct 5, 2017

@rlr looking good. Found one issue when testing the update: After collapsing the section, I get one more view impression ping when opening a new tab, subsequent new tabs are fine. Reopening/Expanding the section works fine too! Turned ping-centre.log on to see this. Happy to help debug this.

@csadilek

This comment has been minimized.

Copy link
Collaborator

commented Oct 6, 2017

@rlr I've just verified that this one additional ping happens after any pref change. So, it's unrelated to your changes. I will take a look and file a follow-up issue, if needed.

UPDATE: Argh, I see it now. We need an additional check for && !isCollapsed here: https://github.com/rlr/activity-streams/blob/9d28eae56b980d89ddfcd2383322d341c695315e/system-addon/content-src/components/Sections/Sections.jsx#L55

The visibility listener could've been attached in a tab where the section was still expanded. So, the section could've been collapsed in the meantime. This only happens for pre-rendered tabs. That's why I was only seeing one additional ping. Sorry for my confusion earlier.

@csadilek
Copy link
Collaborator

left a comment

Found one minor issue (see updated comment above).

@rlr rlr force-pushed the rlr:gh3148/collapsible-sections branch from 9d28eae to 30c4613 Oct 6, 2017

@rlr rlr force-pushed the rlr:gh3148/collapsible-sections branch from d5e790a to edd41d3 Oct 6, 2017

@rlr rlr merged commit e708b26 into mozilla:master Oct 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@as-pine-proxy

This comment has been minimized.

@rlr rlr deleted the rlr:gh3148/collapsible-sections branch Nov 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.