feat (systemaddom): #3148 make the sections (+Top Sites) collapsible #3617
Conversation
rlr
force-pushed the
rlr:gh3148/collapsible-sections
branch
6 times, most recently
from
a203e78
to
a84dab5
|
Works well! Only found one issue: A collapsed section should not send view impressions but currently does, see So, we'd need to find a way to send view impressions when the section is expanded, similar to what we do with the visibility change handler. |
| background-image: url('#{$image-path}glyph-arrowhead-down-12.svg'); | ||
| background-size: $smaller-icon-size; | ||
| height: $smaller-icon-size; | ||
| transform: rotate(270deg); |
Mardak
Oct 5, 2017
Member
Probably need 90deg for rtl?
Probably need 90deg for rtl?
|
@rlr looking good. Found one issue when testing the update: After collapsing the section, I get one more view impression ping when opening a new tab, subsequent new tabs are fine. Reopening/Expanding the section works fine too! Turned ping-centre.log on to see this. Happy to help debug this. |
|
@rlr UPDATE: Argh, I see it now. We need an additional check for The visibility listener could've been attached in a tab where the section was still expanded. So, the section could've been collapsed in the meantime. This only happens for pre-rendered tabs. That's why I was only seeing one additional ping. Sorry for my confusion earlier. |
|
Found one minor issue (see updated comment above). |
Once again, a lot of the code changes is moving stuff around.
Fixes #3148