Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
feat (systemaddom): #3148 make the sections (+Top Sites) collapsible #3617
6 times, most recently
Sep 27, 2017
csadilek left a comment •
Works well! Only found one issue: A collapsed section should not send view impressions but currently does, see
So, we'd need to find a way to send view impressions when the section is expanded, similar to what we do with the visibility change handler.
@rlr looking good. Found one issue when testing the update: After collapsing the section, I get one more view impression ping when opening a new tab, subsequent new tabs are fine. Reopening/Expanding the section works fine too! Turned ping-centre.log on to see this. Happy to help debug this.
UPDATE: Argh, I see it now. We need an additional check for
The visibility listener could've been attached in a tab where the section was still expanded. So, the section could've been collapsed in the meantime. This only happens for pre-rendered tabs. That's why I was only seeing one additional ping. Sorry for my confusion earlier.