Bug 1467485 - Missing screenshots for TopSiteLink components

[imjching]

This fixes the bug in which screenshots for TopSiteLink components are missing.

Before

After

This uses the same logic as the one in #4150. I have extracted out the screenshot logic from the Card component into ScreenshotUtils so that it can be used in the TopSiteLink component as well. The naming in ScreenshotUtils might be confusing at first (RemoteImage, LocalImage). I have added a block of comment in ScreenshotUtils to address that:

/**
 * List of helper functions for screenshot-based images.
 *
 * There are two kinds of images:
 * 1. Remote Image: This is the image from the main process and it refers to
 *    the image in the React props. This can either be an object with the `data`
 *    and `path` properties, if it is a blob, or a string, if it is a normal image.
 * 2. Local Image: This is the image object in the content process and it refers
 *    to the image *object* in the React component's state. All local image
 *    objects have the `url` property, and an additional property `path`, if they
 *    are blobs.
 */

I'm not quite sure if there's a better naming for those, and I am open to suggestions. 😀

[k88hudson]

any particular reason these aren't just regular functions?

[Mardak]

If these were all regular methods on ScreenshotUtils, then there wouldn't need to be a separate _isBlob and a plain isBlob method called from these other methods as this.isBlob(…) ?

[imjching]

Got it! Will update accordingly. 👍

[k88hudson]

Ok, looks good to me. Thanks for fixing this, sorry I missed this in the original review!

[imjching]

Updated the PR to address the comments.