Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

Bug 1519775 - Make one and two-column lists work #4685

Merged
merged 1 commit into from Jan 18, 2019

Conversation

dmose
Copy link
Member

@dmose dmose commented Jan 18, 2019

Looking for a quick-turnaround review so I can get this (layout-breaking) bug in before the impending export and tidy up individual bits of the lists later. Whoever wants this, feel free to take it!

How to test:

The various trending stories should all be appropriate widths.

Things to note:

Known bugs are already captured as dependents of the ds-list-component bug: https://bugzilla.mozilla.org/showdependencytree.cgi?id=1514020&hide_resolved=0

@piatra piatra self-assigned this Jan 18, 2019
@dmose dmose unassigned gvn Jan 18, 2019
@dmose dmose requested review from piatra and removed request for ScottDowne, gvn, Mardak and k88hudson January 18, 2019 17:12
@piatra
Copy link
Contributor

piatra commented Jan 18, 2019

Is this correct? It looks like the extra 16px (592+16) from the 2 column right hand side Trending Stories should go to the 1 column Trending stories (296-16)
image
image
image

@dmose
Copy link
Member Author

dmose commented Jan 18, 2019

I think you're quite possibly right, but I think it's most important to get the fix for this layout bustage into m-c, so I'd propose fixing that in a separate bug.

Copy link
Contributor

@piatra piatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this looks good to me with the followup fix. Thanks.

@piatra piatra assigned dmose and unassigned piatra Jan 18, 2019
@dmose dmose merged commit f558744 into mozilla:master Jan 18, 2019
@dmose dmose deleted the responsive-lists-1519775 branch January 18, 2019 17:31
@dmose
Copy link
Member Author

dmose commented Jan 18, 2019

https://bugzilla.mozilla.org/show_bug.cgi?id=1521128 filed on the space issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants