This repository has been archived by the owner on Feb 29, 2020. It is now read-only.
Bug 1550642 - Improve accessibility of autofocused email #5016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a11y panel picked it up:
|
Mardak
approved these changes
May 10, 2019
|
hmm, looks like we can take out the required and it will still validate for a well formed email address. But if it's empty, it submits. So we could handle the one empty case separately in the |
Mardak
pushed a commit
to Mardak/activity-stream
that referenced
this pull request
May 20, 2019
Mardak
added a commit
that referenced
this pull request
May 21, 2019
* chore(l10n): Update from l10n-central Mon May 20 2019 14:51:14 GMT-0700 (PDT) * Bug 1550723 - An inactive horizontal scrollbar is displayed at the bottom of the about:welcome pages which contain a modal (#5017) * Bug 1550566 - Retrieve `deviceID` parameter from FxA metrics endpoint and append as additional query parameter for FxA flows (#5015) * Bug 1550642 - Improve accessibility of autofocused email (#5016) * Bug 1550614 - Mobile image accidentally includes Lockwise in the background (#5019) * Port 1550572 - More string updates for onboarding messaging r=flod,r1cky (#5021) * Bug 1551207 - No telemetry ping is sent if the "First Run Cards" are dismissed (#5023) * Bug 1551677 - Improve accessibility of trailhead dialog (#5028) * Bug 1551832 - Onboarding button label not wrapping (#5032) * Bug 1550649 - Should not roll trailhead branch if has addons attribution data (#5036) * Bug 1550217 - Pref on Trailhead with desired experimentation for 67.0.5 (#5045) * Bug 1550858 - Update final final final final final actions or urls (#5046) * Bug 1553205 - FxA metrics values sometimes don't get set (#5053)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.