Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

Bug 1561660 - Tweaked CSS for welcome modal on smaller resolutions #5155

Merged
merged 3 commits into from Jul 8, 2019

Conversation

AllegroFox
Copy link
Contributor

No description provided.

@AllegroFox AllegroFox requested a review from Mardak July 3, 2019 22:04
@Mardak Mardak requested a review from k88hudson July 5, 2019 08:45
@Mardak
Copy link
Member

Mardak commented Jul 5, 2019

Probably should check with Aaron on how the join modal should behave. Pretty sure when it was originally implemented, it was desired to not have the modal scroll but to have the modal be a fixed size allowing the page the scroll to see the rest if necessary.

Aaron also wanted the modal to be up higher, but I'm not sure what that means in terms of hiding the "Welcome to Firefox" text

@AllegroFox AllegroFox self-assigned this Jul 5, 2019
@AllegroFox
Copy link
Contributor Author

Request ALL the reviews :)

Copy link
Contributor

@k88hudson k88hudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great

@AllegroFox AllegroFox merged commit 39b6db8 into mozilla:master Jul 8, 2019
Mardak pushed a commit that referenced this pull request Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants