This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Update paths after DevTools file migration #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ({ ConsoleAPI } = Cu.import("resource://gre/modules/devtools/shared/Console.jsm")); | ||
| } catch (e) { | ||
| ({ ConsoleAPI } = Cu.import("resource://gre/modules/devtools/Console.jsm")); | ||
| } |
There was a problem hiding this comment.
Can't you also use require("devtools/import") for Console.jsm?
There was a problem hiding this comment.
I don't have require until the SDK loader is initialized a few lines later, and the console object we're creating is part of the loader's initialization options, so this seemed the simplest thing to do here.
|
r+, tested against nightly and release, works fine without seeing much exception. |
jryans
added a commit
that referenced
this pull request
Sep 29, 2015
Update paths after DevTools file migration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ochameau
Still not functional of course, needs the
TCPSocketfix.Tested on Firefox 44 and 42.