This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Support abstract socket for USB connection #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
approved these changes
Jun 7, 2018
|
By the way, when you are ready to deploy a new version of this add-on, please contact either Alexandre Poirot apoirot@mozilla.com, Julian Descottes jdescottes@mozilla.com on the team. They are the ones that currently have access. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add abstract socket address support to support Android O. When target SDK is 26+, adb cannot connect UNIX domain socket due to no permission by new security feature of Android O (https://bugzilla.mozilla.org/show_bug.cgi?id=1462019). Although Fennec still uses 23 for it, new GeckoView application such as VR Browser and etc will use 26+.
Abstract socket address can still connect it even if Android O and Chrome uses it. So we should support it on adbhelper.
If using abstract socket address, /proc/net/address shows "@" prefix like the following.