bug 895693 - notify title, text accept numbers

and iconURL accepts URL instances.
plus a new test to confirm that.

lib/sdk/notifications.js

@@ -11,6 +11,8 @@ module.metadata = {
 const { Cc, Ci, Cr } = require("chrome");
 const apiUtils = require("./deprecated/api-utils");
 const errors = require("./deprecated/errors");
+const { isString, isUndefined, instanceOf } = require('./lang/type');
+const { URL } = require('./url');
 
 try {
   let alertServ = Cc["@mozilla.org/alerts-service;1"].
@@ -66,16 +68,20 @@ function validateOptions(options) {
       is: ["string", "undefined"]
     },
     iconURL: {
-      is: ["string", "undefined"]
+      is: ["string", "undefined", "object"],
+      ok: function(value) {
+        return isUndefined(value) || isString(value) || (value instanceof URL);
+      },
+      msg: "`iconURL` must be a string or an URL instance."
     },
     onClick: {
       is: ["function", "undefined"]
     },
     text: {
-      is: ["string", "undefined"]
+      is: ["string", "undefined", "number"]
     },
     title: {
-      is: ["string", "undefined"]
-    }
+      is: ["string", "undefined", "number"]
+    },
   });
 }

test/test-notifications.js

@@ -24,6 +24,24 @@ exports.testOnClick = function (assert) {
   loader.unload();
 };
 
+exports['test:numbers and URLs in options'] = function(assert) {
+  let [loader] = makeLoader(module);
+  let notifs = loader.require('sdk/notifications');
+  let opts = {
+    title: 123,
+    text: 45678,
+    // must use in-loader `sdk/url` module for the validation type check to work
+    iconURL: loader.require('sdk/url').URL('data:image/png,blah')
+  };
+  try {
+    notifs.notify(opts);
+    assert.pass('using numbers and URLs in options works');
+  } catch (e) {
+    assert.fail('using numbers and URLs in options should not throw');
+  }
+  loader.unload();
+}
+
 // Returns [loader, mockAlertService].
 function makeLoader(module) {
   let loader = Loader(module);