Bug 958908 - Remove usage of deprecated/observer-service #1343
Conversation
| const core = require("./core"); | ||
| const { id: jetpackId} = require('../self'); | ||
|
|
||
| const OPTIONS_DISPLAYED = "addon-options-displayed"; | ||
|
|
||
| function onOptionsDisplayed(document, addonId) { | ||
| function onOptionsDisplayed({ subjec: documentt, data: addonId }) { |
There was a problem hiding this comment.
This looks confusing; shouldn't it be {subject: document,, even if it's not used
|
You removed |
|
Should also remove the |
looks like @Gozala is ok with this https://bugzilla.mozilla.org/show_bug.cgi?id=943155#c2 |
that'll break some stuff, like the addon-pathfinder, but w/e. |
|
Ya, not sure about leaving it in there or what, but we should remove these things at some point, rather than people using them for new things and having to refactor whenever we do get rid of them |
Conflicts: lib/sdk/content/worker.js lib/sdk/deprecated/symbiont.js
Bug 958908 - Remove usage of deprecated/observer-service r=@jsantell
No description provided.