Bug 741101 – Makes contentStyle* consistent with contentScript* about include match pattern
#394
Conversation
…ude match pattern
| else if (pattern.anyWebPage) { | ||
| documentRules.length = 0; | ||
| documentRules.push("regexp(\"^(https?|ftp)://.*?\")"); |
There was a problem hiding this comment.
I'm ok with this change, but feel bit worried that some add-on's may get broken by this. Could you write about this on mailing list to increase awareness and users to test this. If cfx testall passes all tests I'm r+ on this.
There was a problem hiding this comment.
Could you explain it a bit more? What do you mean with "some add-ons may get broken by this"?
There was a problem hiding this comment.
Currently page mods using "*" would be applied to addon's pages shipped in data folder with your changes they no longer will be applied to them, so there is a risk of someone relying on this.
There was a problem hiding this comment.
I think there is a misunderstanding, this feature is not released yet so we're not going to break any add-on. Currently "_" for contentScript_are already limited to http/https/ftp, this patch makescontentStyle* consistent with that rule.
As described in my previous comment on bugzilla, that's actually don't solve the problem, but limit it, and makes the behavior consistent across
contentStyle*andcontentScript*.