This repository has been archived by the owner on Feb 26, 2022. It is now read-only.
Bug 749749: Fix "test-content-worker.test:setTimeout are unregistered on content unload". #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on content unload". bug 695480 now prevents using unloaded content document references, but we still can use outer window reference until it is finally closed.
| // is going to be released. See bug 695480 | ||
| originalWindow.document.title; | ||
| }, "can't access dead object"); | ||
| } |
There was a problem hiding this comment.
I'm not quite sure how useful this test is, but I'm ok with keeping it.
|
Looks good to me r+ |
|
Also it looks like @Mossop already r+ it. |
ochameau
added a commit
that referenced
this pull request
May 2, 2012
…ker-setTimeout Bug 749749: Fix "test-content-worker.test:setTimeout are unregistered on content unload". r=@Mossop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug 695480 now prevents using unloaded content document references,
but we still can use outer window reference until it is finally closed.
wrappedJSObject, so instead of checkingnode.wrappedJSObject, we have to check forXPCNativeWrapper.unwrap(node) !== node.https://bugzilla.mozilla.org/show_bug.cgi?id=749749