This repository has been archived by the owner on Feb 26, 2022. It is now read-only.
Bug 751546: Fix "dead object" exception in api-utils/tab/observer. #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`deactivate` was fired too lately.
| // Bug 751546: Emit `deactivate` event on window close immediatly | ||
| // Otherwise we are going to face "dead object" exception on `select` event | ||
| if (getActiveTab(chromeWindow) == selectedTab) { | ||
| observer._emit("deactivate", selectedTab); |
There was a problem hiding this comment.
Don't you need to remove _emit('deactivate', ... it from wherever it was called before ?
There was a problem hiding this comment.
I don't think so as I'm nullifying selectedTab.
deactivate seems to be only fired from here:
https://github.com/ochameau/addon-sdk/blob/9ef15ef357a8fc9776fc25b9a8a9903804b5319f/packages/api-utils/lib/tabs/observer.js#L56
But you should have a better picture of this whole API as you wrote it,
so if you think I should do otherwise, please tell me.
There was a problem hiding this comment.
Yeah it's a mess there, but it looks like you're right.
ochameau
added a commit
that referenced
this pull request
May 3, 2012
…bject Bug 751546: Fix "dead object" exception in api-utils/tab/observer. r=@Gozala
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deactivatewas fired too lately.https://bugzilla.mozilla.org/show_bug.cgi?id=751546