This repository has been archived by the owner on Feb 26, 2022. It is now read-only.
Bug 764840: Fix loader leak by using Sandboxes and nuking them instead of JSM. #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function loadSandbox(uri) { | ||
| let proto = { sandboxPrototype: { loadSandbox: loadSandbox } }; | ||
| let module = Cu.Sandbox(systemPrincipal, proto); | ||
| module.__URI__ = uri; |
There was a problem hiding this comment.
I'd rather prefer module.module = { uri: uri, exports: {} }
| // correctly | ||
| sandbox.exports = {}; | ||
| sandbox.module = { uri: uri, exports: sandbox.exports }; | ||
| sandbox.require = function () {}; |
There was a problem hiding this comment.
I don't think it's such a good idea, it may cause surprising race conditions. Either don't expose require or throw some clear message from it.
ochameau
added a commit
that referenced
this pull request
Sep 1, 2012
…ader Bug 764840: Fix loader leak by using Sandboxes and nuking them instead of JSM. r=@Gozala
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next try, after PR #473.
I tried to merge cuddlefish into bootstrap but it ended up being complicated because of manifest.
We have to put fake require statement in
loader.jsand I don't think that we want such noise in toolkit's loader.js ... (That's to be able to loadaddon/runnerfrom bootstrap)So I kept cuddlefish.js and switched to Sandboxes for it and loader.js.
https://bugzilla.mozilla.org/show_bug.cgi?id=764840