Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug 746124 - cfx-js integration work #646

Merged
merged 1 commit into from Jun 13, 2013

Conversation

Projects
None yet
2 participants
Member

Gozala commented Nov 1, 2012

This is work is pool of changes required for integrating cfx-js linker

With this changes inn and clone of cfx-js under addon-sdk/cfx all the tests pass both on cfx-py and node. In other words this how you test it:

cd addon-sdk
git clone git://github.com/Gozala/cfx-js.git cfx
cd cfx

cfx test
Using binary at '/Applications/Firefox.app/Contents/MacOS/firefox-bin'.
Using profile at '/var/folders/0z/nztt5n4d4kg7b43dg9nv_3fc0000gp/T/tmpitLfnV.mozrunner'.
Running tests on Firefox 15.0/Gecko 15.0 ({ec8030f7-c20a-464f-9b0e-13a3a9e97384}) under darwin/x86.
..............................................................
62 of 62 tests passed.
Total time: 3.451745 seconds
Program terminated successfully.


npm test
Running all tests:
..............................................................
Passed:62 Failed:0 Errors:0
Member

Gozala commented Nov 17, 2012

For more details see #578

@ghost ghost assigned erikvold Nov 17, 2012

Contributor

erikvold commented Jan 18, 2013

I'll review the rest tonight, but one thing I notice now is that we should mention the Node license in https://github.com/mozilla/addon-sdk/blob/master/LICENSE

Contributor

erikvold commented Jan 19, 2013

@Gozala I think we ought to include the tests for these modules, because they will be available to add-ons to use, which means they'll probably be used..

Also we'll be awfully tempted to use the modules..

@erikvold erikvold commented on an outdated diff Jun 12, 2013

python-lib/cuddlefish/manifest.py
@@ -461,7 +461,9 @@ def BAD(msg):
raise BAD("no actual modulename")
if bits[0] == "..":
if not them:
@erikvold

erikvold Jun 12, 2013

Contributor

Not really sure why this change was made.

@erikvold

erikvold Jun 12, 2013

Contributor

the tests seem to pass without these changes.

Contributor

erikvold commented Jun 13, 2013

r+ w/out the python change

@Gozala Gozala added a commit that referenced this pull request Jun 13, 2013

@Gozala Gozala Merge pull request #646 from Gozala/jep/cfx-js
Bug 746124 - Implement nodejs compatible `fs` and `path` modules.
93aba87

@Gozala Gozala merged commit 93aba87 into mozilla:master Jun 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment