This repository has been archived by the owner on Feb 26, 2022. It is now read-only.
bug 796917 using postMessage to an iframe from a content script does not serialize data #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent script does not serialize data
| jscode += JSON.stringify(message); | ||
| else | ||
| jscode += "'" + message.toString().replace(/['\\]/g,"\\$&") + "'"; | ||
|
|
There was a problem hiding this comment.
Maybe we should have a function for that.
There was a problem hiding this comment.
I can't require in to this file I think, it's only used in this one spot atm, which is mostly a isolated function, it just does the eval afterewards too. So I'm just going to leave this for now, hopefully we can remove all of this code soon too.
|
@ochameau What happened with removal of content-proxy ? Is there anything blocking us from doing it ? |
erikvold
added a commit
that referenced
this pull request
Nov 5, 2012
fix bug 796917 using postMessage to an iframe from a content script does not serialize data r=@Gozala
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.