This repository has been archived by the owner on Feb 26, 2022. It is now read-only.
Bug 854980 - Implementing simple utils for observing window / tab events #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function dispatch({ type, subject }) { | ||
| emit(channel, "data", { | ||
| topic: type, | ||
| type: topics[type], |
There was a problem hiding this comment.
topic = type and type = topics[type] seems ver confusing
can we do topic = topic and type = types[topic] ?
There was a problem hiding this comment.
How about this ?
function dispatch({ type: topic, subject }) {
emit(channel, "data", {
type: types[topic],
topic: topic,
target: subject
})
}There was a problem hiding this comment.
ya this looks much better!
Gozala
added a commit
that referenced
this pull request
Apr 1, 2013
Bug 854980 - Implementing simple utils for observing window / tab events r=@Mossop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces foundation that would allow decoupling tabs from windows so that each of them can be de-traitified separately. It also introduces replacement for a deprecated
WindowTrackeras a part of this work.