New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create GlobalLinterMessages component #872 #893
create GlobalLinterMessages component #872 #893
Conversation
Codecov Report
@@ Coverage Diff @@
## master #893 +/- ##
======================================
Coverage 98.8% 98.8%
======================================
Files 53 54 +1
Lines 1673 1673
Branches 402 402
======================================
Hits 1653 1653
Misses 19 19
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great so far, thanks for getting this started. I have a few change requests but nothing major. Let me know if you have questions.
405047e
to
2fe6782
Compare
@kumar303 I believe I addressed all comments.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed review. I answered your ref question and had a few other change requests, mostly minor cleanup.
2fe6782
to
8aebe07
Compare
Thanks for reviewing @kumar303 . I updated and rebased it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking very good but I noticed a couple small issues.
The snyk failure has been fixed on master so you can rebase again to get the fix (sorry about all the rebasing!) |
8aebe07
to
95993e4
Compare
Updated! :) @kumar303 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the quick follow-ups!
Fixes #872
@kumar303
In refactoring, I found scrolling to linter messages in different files is not work well (Not sure why..) #887 (comment).
I tested some pages, this refactoring does not change behaviors when navigating between linter messages.