Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocomplete to search component #9855

Closed
tofumatt opened this issue Sep 17, 2016 · 2 comments
Closed

Add autocomplete to search component #9855

tofumatt opened this issue Sep 17, 2016 · 2 comments

Comments

@tofumatt
Copy link
Contributor

#9768 includes an autocomplete in the search page, which we will need to add to it.

The current AMO has autocomplete but the autocompete results seem different to the actual search results.

I'd like a consistent search experience so I want the results to be the same as the add-ons search in terms of order/etc. But hammering the search API onChange and getting all that data back is likely overkill, so we may need to add a param to the search API for autocomplete.

@tofumatt
Copy link
Contributor Author

Ohai, @willdurand did this already for mozilla/addons-frontend#2971. This is basically a duplicate of #10554.

@willdurand
Copy link
Member

Haha looks like I can close issues even when I am off
☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants