New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search hints/autocomplete #10554
Comments
The API endpoint has been implemented in mozilla/addons-server#5930, and the API doc is here: https://addons-server.readthedocs.io/en/latest/topics/api/addons.html#autocomplete. |
@pwalm Hi, I am a bit confused by the new mockups. I have exported the latest version below: What is the first set of entries/suggestions? In the previous mockups, it was about suggestions to help users type right, but now it seems to be different. At first glance, I thought this first set represented a history (previous/past searchs). Yet, because there is also a second set with icons and arrows, I am not sure about what the first set actually is. If there is an arrow and the icon of a well identified add-on, then I would expect to redirect to the add-on page directly on click/tap, and not to fill the input and trigger the search process. Could you please give more details about the autocomplete/auto-suggest feature? Thank you! |
I think the first set of menu items are suggestions for search terms and the second set are suggestions for search results. However, the API only returns suggested search results so let's start by implementing that. |
Updating milestone. |
@kumar303 Is correct! First three: search terms. Second three: search results. I can actually make this clearer by adding subheads if we need to, we've done it for some other drop-downs in the header already: |
@pwalm Yeah, I think the subheaders make it a lot clearer, and since we use them elsewhere in similar elements I say 👍 |
@diox if you take a look at the mock in #10554 you'll see that the first three items are suggested search terms (not results). I assume that would be pretty tricky to implement in the API since we don't currently keep a record of what people typed (other than in request logs). @pwalm could you add a little bit of rationale for including suggested terms? Would these potentially help users find what they're looking for in ways that suggested results would not? |
Verified the fix from #3233 using FF55(Win 7, Android 7.2.1) |
Add a search hint/autocomplete as per mocks. Relies on #3521.
The text was updated successfully, but these errors were encountered: