Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discopane tests are hitting the dev server. Burn them with fire. #10074

Closed
kumar303 opened this issue Feb 4, 2017 · 4 comments
Closed

Discopane tests are hitting the dev server. Burn them with fire. #10074

kumar303 opened this issue Feb 4, 2017 · 4 comments
Labels
repository:addons-frontend Issue relating to addons-frontend

Comments

@kumar303
Copy link
Contributor

kumar303 commented Feb 4, 2017

The add-ons dev server went down and discopane tests mysteriously started failing. When dev came back online, the tests passed.

screenshot 2017-02-03 17 52 50

Let's figure out why.

wezhou said the CDN was not affected but all app services were down.

@mstriemer
Copy link
Contributor

I think these tests just point at -dev for the API, which is why they fail if -dev is down.

The disco tests explicitly set the apiHost in config/test-disco.js but it looks like the default for tests is http://localhost though config/test.js.

@muffinresearch
Copy link
Contributor

muffinresearch commented Feb 6, 2017

Duplicate of #9886

@muffinresearch
Copy link
Contributor

muffinresearch commented Feb 6, 2017

Duplicate of #9886

Reading #9886 which resulted in the duping of #9759 I wonder if this should be re-opened since there's something of a distinction between server tests using a real api versus forgetting to mock api calls in a test - albeit they are related?

@kumar303
Copy link
Contributor Author

kumar303 commented Feb 6, 2017

ha! I can't even remember what I did 5 minutes ago.

I don't really know what's happening but we should fix it. I would love to cripple all network connectivity at the start of any test suite similar to how we do it in nose-blockage (which patches all network utilities).

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Development

No branches or pull requests

5 participants