Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts for add-ons in horizontal card view should be modified #2661

Closed
tofumatt opened this issue Jul 1, 2017 · 7 comments
Closed

Fonts for add-ons in horizontal card view should be modified #2661

tofumatt opened this issue Jul 1, 2017 · 7 comments

Comments

@tofumatt
Copy link
Contributor

tofumatt commented Jul 1, 2017

@sarahmonster pointed out that a larger font size with a lighter font weight would look good for the desktop horizontal card add-ons. She suggested:

font-size: 18px;
font-weight: 500;
line-height: 1.2;

and it looked good, so I'll do that. I think that's closer to the mocks anyway and I sized them down like a doofus.

@aayushsanghavi
Copy link
Contributor

aayushsanghavi commented Jul 6, 2017

@tofumatt if you don't mind, could I work on this? Also, could you tell me which component are we talking about here (a screenshot of the page, perhaps)?

@tofumatt
Copy link
Contributor Author

tofumatt commented Jul 6, 2017

It's the AddonsCard component in the amo app when type="horizontal" is set. It appears on the desktop pages at /extensions and /themes

@aayushsanghavi
Copy link
Contributor

@tofumatt I tried it but when I inserted those rules after this line the children elements rejected them; they were overridden by other css rules that the children elements inherited from other elements. I'm definitely not doing the right thing. Suggestion on how could I fix it, please :)

@tofumatt tofumatt modified the milestones: 2017.07.20, 2017.07.13 Jul 11, 2017
@tofumatt tofumatt modified the milestones: 2017.07.27, 2017.07.20 Jul 19, 2017
@tofumatt
Copy link
Contributor Author

Turns out we were actually overriding these styles on desktop which is silly, so just gonna remove them.

@ValentinaPC
Copy link

ValentinaPC commented Jul 26, 2017

Verified this on AMO-dev FF54(Win 7).
@tofumatt Did you kept the suggested dimensions?
Because I've checked in extensions and themes homepages and seems like the font-size is 14px and not 18px, font-weight is 400 and not 500; line-height is ok - 1.2;
Screenshots:
2017-07-26_1726

@tofumatt
Copy link
Contributor Author

tofumatt commented Jul 26, 2017 via email

@ValentinaPC
Copy link

Based on above comments we can mark this verified fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants