Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized "Featured Add-On" string is still in English for all languages #2032

Open
peiying2 opened this issue Nov 14, 2017 · 8 comments
Open
Labels
repository:addons-frontend Issue relating to addons-frontend

Comments

@peiying2
Copy link

peiying2 commented Nov 14, 2017

Describe the problem and steps to reproduce it:

https://addons.mozilla.org/nl/firefox/collections/mozilla/featured-add-ons/ - first reported in bug 1417120 but it looks like the issue exists in all languages

What happened?

Localized string is not displayed on production, even though the string was translated several weeks ago.

What did you expect to happen?

Localized string displayed at this prominent spot.

Anything else we should know?

https://addons.mozilla.org/nl/firefox/collections/mozilla/featured-add-ons/ (change locale code, you will see the issue is common for all locales.

┆Issue is synchronized with this Jira Task

@peiying2
Copy link
Author

@muffinresearch

@muffinresearch
Copy link
Contributor

@peiying2 this is because these areas of the site use DB data and cannot be easily localized by the typical l10n methods. We're going to look into options for localizing this content.

@peiying2
Copy link
Author

Looks like the issue is still not fixed.

@willdurand willdurand reopened this Jul 31, 2019
@willdurand
Copy link
Member

Sorry, I closed this issue because there is no featured collection anymore.

@peiying2
Copy link
Author

Sorry, I closed this issue because there is no featured collection anymore.

Thanks for providing some background on the resolution. Let's close it then.

@willdurand
Copy link
Member

I think the bug is still valid though, because we have "Recommended Extensions" now and I suppose the problem persists.

@peiying2
Copy link
Author

I thought it was just the string change of the same "feature". If that's the case, let's fix it. It is a pretty important string come to think of it, if we want users to check out what's recommended.

@KevinMind
Copy link
Contributor

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 3, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 3, 2024
@diox diox removed triaged labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Development

No branches or pull requests

8 participants