-
Notifications
You must be signed in to change notification settings - Fork 41
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Undo" drop down bar should be removed when a theme is uninstalled via on\off radio button #9728
Comments
We need to work out what browser APIs exist to do this since this the display of the bar is something that happens indirectly as a result the theme installation and isn't something that's triggered from the page explicitly. @aswan any thoughts? |
This seems like something that the browser should be doing automatically (i.e., if there is a change to the theme's status coming from somewhere other than the bar, the bar should be dismissed). I'm not familiar with the existing code that displays that bar so I don't know how difficult that would be, but can you open a Firefox bug? |
In future, it would be great to see themes show the same behavior than extension: |
@designakt yep I agree, if we can stop the default behaviour then we can implement the notification / UiTour for themes too. |
Bugzilla Bug was marked as "Resolved duplicate". |
Resolved upstream nothing to do here. |
Prerequisites:
Build identifier: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0
Steps to reproduce:
1.Follow instructions from https://wiki.mozilla.org/Add-ons/Projects/DiscoveryImprovements#Testing in order to set up the new disco pane on Nightly, AMO-dev
2.Install a new theme from about:addons(observe the "Undo" and "Manage Themes" drop down bar after a successful installation)
3.From on\of radio button, remove the theme
Expected results:
The "Undo" bar should be closed when a theme is uninstalled
Actual results:
"Undo" bar is still displayed
Please see video for this bug :
The text was updated successfully, but these errors were encountered: