Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Undo" drop down bar should be removed when a theme is uninstalled via on\off radio button #9728

Closed
vcarciu opened this issue Jul 4, 2016 · 7 comments
Assignees
Labels
repository:addons-frontend Issue relating to addons-frontend

Comments

@vcarciu
Copy link

vcarciu commented Jul 4, 2016

Prerequisites:
Build identifier: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0

Steps to reproduce:
1.Follow instructions from https://wiki.mozilla.org/Add-ons/Projects/DiscoveryImprovements#Testing in order to set up the new disco pane on Nightly, AMO-dev
2.Install a new theme from about:addons(observe the "Undo" and "Manage Themes" drop down bar after a successful installation)
3.From on\of radio button, remove the theme

Expected results:
The "Undo" bar should be closed when a theme is uninstalled

Actual results:
"Undo" bar is still displayed

Please see video for this bug :
undo

@muffinresearch
Copy link
Contributor

We need to work out what browser APIs exist to do this since this the display of the bar is something that happens indirectly as a result the theme installation and isn't something that's triggered from the page explicitly.

@aswan any thoughts?

@aswan
Copy link

aswan commented Jul 5, 2016

This seems like something that the browser should be doing automatically (i.e., if there is a change to the theme's status coming from somewhere other than the bar, the bar should be dismissed). I'm not familiar with the existing code that displays that bar so I don't know how difficult that would be, but can you open a Firefox bug?

@muffinresearch
Copy link
Contributor

@designakt
Copy link
Contributor

In future, it would be great to see themes show the same behavior than extension:
Show a door-hanger confirming install instead of the notification bar.
(Unifies UI for users, and we would not need to maintain 2 separate systems)

@muffinresearch
Copy link
Contributor

@designakt yep I agree, if we can stop the default behaviour then we can implement the notification / UiTour for themes too.

@Ryuno-Ki
Copy link

Bugzilla Bug was marked as "Resolved duplicate".

@muffinresearch
Copy link
Contributor

Resolved upstream nothing to do here.

@ghost ghost assigned muffinresearch Feb 14, 2017
@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Development

No branches or pull requests

6 participants