Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge "amo" and "core" packages #13865

Closed
willdurand opened this issue Oct 27, 2020 · 8 comments · Fixed by mozilla/addons-frontend#9983
Closed

Merge "amo" and "core" packages #13865

willdurand opened this issue Oct 27, 2020 · 8 comments · Fixed by mozilla/addons-frontend#9983
Assignees
Labels
Milestone

Comments

@willdurand
Copy link
Member

This is only be possible after #13735. We only have one app in this project so let's remove the amo and core folders and merge some of the common files together.

For QA: this is a major code change but it shouldn't have any impact on the site.

@lakshyabatman
Copy link

Hello, I'm interested to work on this issue as well. Please let me know if it's possible. Thankyou.

@willdurand
Copy link
Member Author

No, it's not, sorry.

@lakshyabatman
Copy link

No problem, thankyou.

@willdurand
Copy link
Member Author

You can find issues by looking at the opened contrib: welcome issues.

@bobsilverberg
Copy link
Contributor

@willdurand After mozilla/addons-frontend#9872 lands, we'll be one step closer to being able to do this. I was thinking we might want to continue taking small steps, as opposed to just trying to merge all of the code in one big patch. For example, maybe we can start by moving individual things out of core and into amo? What do you think of taking that approach?

Also, do you imagine that everything will end up in amo, or do you envision doing away with both amo and core and just having everything live under src?

@willdurand
Copy link
Member Author

I think we can get rid of both amo and core. We can land incremental patches.

@willdurand
Copy link
Member Author

willdurand commented Jan 12, 2021

Here is the plan:

  1. move core sources to amo (we need a directory level in src/ otherwise it breaks our absolute imports)
  2. move core test files to amo
  3. move core stories to amo

It will require 2 or 3 PRs I think.

I'll file an issue for the ui package (edit: see #13927)

@ioanarusiczki
Copy link

@willdurand Looks good. Release testing is completed - on AMO stage with FF84(Win).

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants