Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clean-script #113

Merged
merged 1 commit into from
Mar 11, 2016
Merged

Conversation

muffinresearch
Copy link
Contributor

"version-check": "node bin/version-check.js"
"build": "npm run clean && npm run version-check && NODE_ENV=production webpack --verbose --display-error-details --progress --colors --config src/config/webpack.prod.config.babel.js",
"version-check": "node bin/version-check.js",
"clean": "rm -rf ./dist/*.{css,js,map} ./src/webpack-assets.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work on Windows? Think of the contributors!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added rimraf instead.

@tofumatt tofumatt self-assigned this Mar 11, 2016
@tofumatt
Copy link
Contributor

r+wc

"version-check": "node bin/version-check.js"
"build": "npm run clean && npm run version-check && NODE_ENV=production webpack --verbose --display-error-details --progress --colors --config src/config/webpack.prod.config.babel.js",
"version-check": "node bin/version-check.js",
"clean": "rimraf './dist/*+(css|js|map)' './src/webpack-assets.json'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

muffinresearch added a commit that referenced this pull request Mar 11, 2016
@muffinresearch muffinresearch merged commit a06a942 into mozilla:master Mar 11, 2016
@muffinresearch muffinresearch deleted the clean-script branch March 11, 2016 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants