Use constants for redux action types. #1281
Merged
+72
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should capture the remaining types from #1087
mstriemer
approved these changes
Oct 25, 2016
There was a problem hiding this comment.
Thanks! This is definitely a step in the right direction 😄.
I've filed #1299 to expand on this some more but there could be some discussion there first, thanks for making this change and bringing it back into my mind.
Can you format your commit messages like this in the future: Brief description without a period (fixes #1087). You're welcome to include more in the body like you did but if it can all fit on one line that's even better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should capture the remaining types from mozilla/addons#9857