Fix theme module layout #1872
Merged
Fix theme module layout #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muffinresearch
commented
Feb 22, 2017
| width: 100%; | ||
|
|
||
| [dir=rtl] & { | ||
| object-position: top left; |
There was a problem hiding this comment.
One thing, I'm not sure if a real RTL browser will show a theme back to front? If so we should transform the images and do the same thing in the details page too.
tofumatt
approved these changes
Feb 23, 2017
| @@ -84,4 +86,42 @@ describe('<SearchResult />', () => { | |||
| assert.equal(node.textContent, | |||
| `Rated ${fakeAddon.ratings.average} out of 5`); | |||
| }); | |||
|
|
|||
| it('Displays a placeholder if the icon is malformed', () => { | |||
There was a problem hiding this comment.
The nit-pickiest of all nitpicks but the "D" should be lowercased here.
| }); | ||
|
|
||
|
|
||
| it('Adds theme specific class', () => { |
There was a problem hiding this comment.
Same as above; our style has been to use lowercase for the test descriptions.
muffinresearch
force-pushed
the
fix-theme-module-layout
branch
from
cd515d3
to
e23439a
Compare
muffinresearch
force-pushed
the
fix-theme-module-layout
branch
from
e23439a
to
4bbfd3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#10105
Fixes the theme layout - I made an assumption that we'd want to keep ratings. I also didn't look at the hyphenating of the text since that's covered elsewhere and needs discussion anyway.
Before:
After:
I also added some belt and braces fallbacks if images aren't set. End users are unlikely to see this but it covers the eventuality and we already did this on the details page for icons.
It will need extending for themes details pages at some point too but that could be done when revisiting the functionality for trying on a theme.
Extensions:
Themes:
