chore: Remove NSP ignore now that fix is deployed #4028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tofumatt there is a fix for moment now (to get rid of the other exception). |
|
Hah, cool, I was about to check that too. I guess I could do them in the same PR. |
Codecov Report
@@ Coverage Diff @@
## master mozilla/addons-frontend#4028 +/- ##
======================================
Coverage 96.4% 96.4%
======================================
Files 186 186
Lines 3950 3950
Branches 805 805
======================================
Hits 3808 3808
Misses 122 122
Partials 20 20Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix mozilla/addons#10799
Pretty sure we fixed this, will let the tests run to make sure.