Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input text color on dark GTK themes (fix mozilla/addons#657) #4531

Merged
merged 1 commit into from Mar 9, 2018

Conversation

futpib
Copy link
Contributor

@futpib futpib commented Mar 9, 2018

Fixes mozilla/addons#657.

This sets explicit color for input, textarea.

Before:
screenshot_20180310_001049

After:
screenshot_20180310_000638

@futpib futpib force-pushed the dark-gtk-theme-text-contrast-fix branch from a04fa61 to 9aa5206 Compare March 9, 2018 21:21
@codecov-io
Copy link

codecov-io commented Mar 9, 2018

Codecov Report

Merging #4531 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4531   +/-   ##
=======================================
  Coverage   95.34%   95.34%           
=======================================
  Files         198      198           
  Lines        4602     4602           
  Branches      944      944           
=======================================
  Hits         4388     4388           
  Misses        188      188           
  Partials       26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abab915...9aa5206. Read the comment docs.

Copy link
Contributor

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks for the fix 👍

@tofumatt tofumatt merged commit 8f4a3fc into mozilla:master Mar 9, 2018
@caitmuenster
Copy link

Thanks so much, @futpib! Your contribution has been added to our recognition wiki.

Would you be interested in creating an account on mozillians.org? I'd be happy to vouch for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants