chore: add API for edit user profile (#4668) #4721
Conversation
tofumatt
force-pushed
the
feat/edit-user-profile-reducers-4668
branch
from
05c1ee0
to
c9c0f1d
Compare
tofumatt
changed the title
| expect(() => { | ||
| currentUserAccount({}); | ||
| }).toThrowError(/api state is required/); | ||
| const getParams = (params = {}) => { |
There was a problem hiding this comment.
This is just a nit; take it or leave it. Considering that there's only one test that makes use of it, this getParams function is kind of unnecessary. It does seem like a good model to follow, and I know we use it in other test files. I notice the same model is followed for the other tests in this file, which also don't really need it. If more tests are added later it would be useful, but at this point none of these cases seems to need more tests.
There was a problem hiding this comment.
I think it's just a best practice we have tried to follow with test params. I might add more tests later that check if optional props are omitted, so I think it's worth keeping. It's a good point about the other tests but if we don't do this we often end up with messy tests, so I think I'm just in the habit of future-proofing them now. It makes anything that copies these tests nicer.
Gonna do the API/reducer/saga stuff for this all separately and maybe it'll make the PRs nice and easy.
Here's the API and tests for editing a user profile. I've exclude the image upload for now as I'll do that last.
Part of #4668.