Switch to firefox dev edition #5779
Conversation
willdurand
force-pushed
the
travis-ff-dev
branch
2 times, most recently
from
ffbca94
to
8199876
Compare
willdurand
force-pushed
the
travis-ff-dev
branch
from
8199876
to
b603354
Compare
Codecov Report
@@ Coverage Diff @@
## master mozilla/addons-frontend#5779 +/- ##
=======================================
Coverage 97.25% 97.25%
=======================================
Files 228 228
Lines 5678 5678
Branches 1093 1093
=======================================
Hits 5522 5522
Misses 136 136
Partials 20 20Continue to review full report at Codecov.
|
.travis.yml
Outdated
| addons: | ||
| firefox: latest-nightly | ||
| hosts: example.com | ||
| env: ALLOWED_TO_FAIL=1 TOXENV=discopane-ui-tests GECKODRIVER=0.20.1 MOZ_HEADLESS=1 PATH=./node_modules/.bin:$PATH |
There was a problem hiding this comment.
If this is allowed to fail, no one will care about it. I don't think it will be helpful to add an additional stage here.
There was a problem hiding this comment.
Well, I will care about it. Otherwise, how do we know if this gets fixed on Nightly?
There was a problem hiding this comment.
Otherwise, how do we know if this gets fixed on Nightly?
The person looking into fixing the tests for Nightly would be running it locally.
But, sure, that's fine if you want to leave in a new stage temporarily while someone works on a fix.
.travis.yml
Outdated
| @@ -55,7 +55,7 @@ jobs: | |||
| - stage: | |||
| <<: *tox | |||
| addons: | |||
| firefox: latest-nightly | |||
| firefox: latest-dev | |||
There was a problem hiding this comment.
I think this is fine as a temporary fix. I would like to see latest-nightly commented out with a link to a bug for re-enabling it. We should unblock master then investigate why it's failing on Nightly and try to get back on Nightly.
.travis.yml
Outdated
| @@ -55,7 +55,7 @@ jobs: | |||
| - stage: | |||
| <<: *tox | |||
| addons: | |||
| firefox: latest-nightly | |||
| firefox: latest-dev | |||
There was a problem hiding this comment.
Is there a bug on file for putting the tests back on Nightly? I'd like to see a comment here with that bug link.
There was a problem hiding this comment.
|
There is a new issue on |
Refs mozilla/addons#12140
This PR changes the Firefox version from nightly to dev edition in order
to get a green feedback again. The issue is related to a "menu" button
not being found anymore. All FF versions < 63 are not affected.
I added a job for nightly so that we can keep an eye on it, but this job
won't fail the build at least.